Skip to content

Conversation

rogerhu
Copy link

@rogerhu rogerhu commented Dec 8, 2021

What I did

  • Put breakpoints on line 93 and 102:
    for _, node := range nodes {
    // Don't start this service yet if all of its children have
    // not been started yet.
    if len(traversalConfig.filterAdjacentByStatusFn(graph, node.Service, traversalConfig.adjacentServiceStatusToSkip)) != 0 {
    continue
    }
    node := node
    eg.Go(func() error {
    err := fn(ctx, node.Service)
    if err != nil {
    return err
    }
    graph.UpdateStatus(node.Service, traversalConfig.targetServiceStatus)
    return run(ctx, graph, eg, traversalConfig.adjacentNodesFn(node), traversalConfig, fn)

Related issue

Watch every so often the output vary between GOOD:

kochiku_redis
kochiku_mysql
kochiku_build

Versus BAD:

kochiku_redis
kochiku_mysql
kochiku_build
kochiku_build

@milas
Copy link
Contributor

milas commented Sep 26, 2022

See #9878 for a fix. Thanks for the repro case!

@milas milas closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants