Skip to content

Add python-dotenv to delegate .env file processing #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

Add python-dotenv to delegate .env file processing #7150

merged 1 commit into from
Jan 27, 2020

Conversation

ulyssessouza
Copy link
Collaborator

@ulyssessouza ulyssessouza commented Jan 16, 2020 •
edited
Loading

Resolves: #6511
Resolves: #6838
Resolves: #2854

Closes: #6897
Closes: #6923

The newest version (0.10.5) of python-dotenv includes my empty value support PR.

@ulyssessouza ulyssessouza self-assigned this Jan 16, 2020
aiordache
aiordache approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@aiordache aiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza mentioned this pull request Jan 16, 2020
Merged
@bbc2
Copy link

bbc2 commented Jan 19, 2020

Version 0.10.5 of Python-dotenv is out.

willbarton
willbarton approved these changes Jan 24, 2020
View reviewed changes
Copy link

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #6511 for me!

@hirochachacha hirochachacha mentioned this pull request Jan 25, 2020
Closed
@ulyssessouza
Add python-dotenv
6d2658e 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@ulyssessouza ulyssessouza marked this pull request as ready for review January 27, 2020 13:44
@ulyssessouza ulyssessouza changed the title Add python-dotenv Add python-dotenv to delegate .env file processing Jan 27, 2020
@ulyssessouza ulyssessouza merged commit 409a9d8 into docker:master Jan 27, 2020
@morganchristiansson morganchristiansson mentioned this pull request Jan 27, 2020
Closed
@cailloumajor cailloumajor mentioned this pull request Jul 28, 2020
Closed
@dominikbraun dominikbraun mentioned this pull request Aug 6, 2020
Closed
@mrmachine mrmachine mentioned this pull request Apr 8, 2021
Open
@antoineco antoineco mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@rumpl rumpl Awaiting requested review from rumpl

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@chris-crone chris-crone Awaiting requested review from chris-crone

+2 more reviewers

@aiordache aiordache aiordache approved these changes

@willbarton willbarton willbarton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ulyssessouza ulyssessouza

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable name may not contain whitespace .env with export Lines No Longer Works Inconsistent env var parsing from docker-compose.yml
6 participants
@ulyssessouza @bbc2 @agronholm @ndeloof @aiordache @willbarton