Added support for quoted env vars #6923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kamerman <stevekamerman@gmail.com>
|
I understand that this change will also affect the documentation, so I'm happy to put in a PR for that as well. |
This was referenced Oct 27, 2019
|
Ping @ulyssessouza @ndeloof @rumpl Any chances this will be merged? |
|
The PR was closed in favor of the adoption of |
|
I don't know how Can anyone clarify? edit: I think this PR is from before docker-compose was rewritten in Go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kamerman stevekamerman@gmail.com
Resolves #2854
This PR adds support for environment variables in
.envfiles with quoted values. The quotes can be single'or double", but must be the same on both ends of the value, and must immediately follow the=.Example:
It also unescapes escaped quotes, like
\":Value:
this is a "quoted" testAll functionality is tested.
This problem has been thoroughly discussed in issue #2854 and there are many reasons for why docker-compose should support this.