Do not error out on lines containg spaces #6897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "do-not-error-on-export-env-variables" git@github.com:Quintasan/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
This is a breaking change - #6511 Signed-off-by: Michał Zając <michal.zajac@gmail.com>
|
The PR was closed in favor of the adoption of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, instead of breaking workflows for existing users. I believe that at this point the spec needs to be adjusted to explicitly tell users that lines not conforming to the
VAR=VALsyntax will be ignored.Should this behaviour turn out to be a huge problem then it can be changed again but with a deprecation notice and a spec change.
There is a feature request for a switch that would prevent docker-compose from reading
.envbut it only solves the problem ofI don't want docker-compose to use my .env file at all(#6741). It's implemented in #6850.This merge request should be merged with docker/docs#9467 so that the spec reflects the actual behaviour.
Resolves #6511, #6838