Skip to content

Conversation

hirochachacha
Copy link

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "feature/reject_environment_variable_that_contains_white_spaces" git@github.com:hirochachacha/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@hirochachacha hirochachacha force-pushed the feature/reject_environment_variable_that_contains_white_spaces branch from aaf74f8 to 8e6f220 Compare December 7, 2018 08:18
@hirochachacha hirochachacha force-pushed the feature/reject_environment_variable_that_contains_white_spaces branch from 8e6f220 to 56bc3d1 Compare December 7, 2018 08:22
@hirochachacha hirochachacha force-pushed the feature/reject_environment_variable_that_contains_white_spaces branch 2 times, most recently from 195a45b to 4086742 Compare December 7, 2018 09:02
Copy link

@shin- shin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few minor changes, otherwise LGTM!

Signed-off-by: Hiroshi Ioka <hirochachacha@gmail.com>
@hirochachacha hirochachacha force-pushed the feature/reject_environment_variable_that_contains_white_spaces branch from 4086742 to afc161a Compare December 11, 2018 03:58
@shin- shin- merged commit afc161a into docker:master Dec 14, 2018
@shin-
Copy link

shin- commented Dec 14, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants