-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add go as a prerequisite in build instructions #13131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @mattrunyon |
BUILDING.md
Outdated
@@ -4,12 +4,15 @@ | |||
* Windows: | |||
* [Docker Desktop](https://docs.docker.com/desktop/setup/install/windows-install/) | |||
* make | |||
* go >= 1.23.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if you should not just link to the go.mod file to avoid managing the sync and be at some point desynchronize, wdyt?
* go >= 1.23.10 | |
* go >= check version used in the [go.mod](go.mod) file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea. I updated it to link to go.mod
Signed-off-by: Matthew Runyon <matthewrunyon@deephaven.io>
8ba7526
to
243ad78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🙏
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.39.1` -> `v2.39.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.39.2`](https://github.com/docker/compose/releases/tag/v2.39.2) [Compare Source](docker/compose@v2.39.1...v2.39.2) #### What's Changed ##### 🐛 Fixes - Fix (regression): compose build render build output with tty support by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13107 - Add missing `_MODEL` suffix to model variable pass to dependent services of a model by [@​glours](https://github.com/glours) in docker/compose#13109 - Apply `BUILDKIT_PROGRESS` value when building with bake by [@​glours](https://github.com/glours) in docker/compose#13110 - Define `pull` and `no_cache` from either service or flags values when building with bake by [@​glours](https://github.com/glours) in docker/compose#13133 - Only monitor attached services on `up` command by [@​glours](https://github.com/glours) in docker/compose#13114 ##### 🔧 Internal - Add Streams Comment by [@​suwakei](https://github.com/suwakei) in docker/compose#13103 - Add test of `json.go` by [@​suwakei](https://github.com/suwakei) in docker/compose#13106 - Refactoring of redundant condition checks by [@​suwakei](https://github.com/suwakei) in docker/compose#13104 - Eliminated magic string by [@​suwakei](https://github.com/suwakei) in docker/compose#13105 - Use log API for containers we didn't attached to by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13111 - Use `cli-plugins/metadata` package by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13130 - `pkg/compose`: simplify getting auth-config key by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13120 - Add go as a prerequisite in build instructions by [@​mattrunyon](https://github.com/mattrunyon) in docker/compose#13131 ##### ⚙️ Dependencies - Build(deps): bump github.com/docker/cli from `28.3.2+incompatible` to `28.3.3+incompatible` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13116 - Build(deps): bump github.com/docker/docker from `28.3.2+incompatible` to `28.3.3+incompatible` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13115 - Build(deps): bump github.com/containerd/containerd/v2 from `2.1.3` to `2.1.4` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13119 - Build(deps): bump github.com/docker/go-connections from `0.5.0` to `0.6.0` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13137 - Build(deps): bump golang.org/x/sys from `0.34.0` to `0.35.0` by [@​dependabot](https://github.com/dependabot)\[bot] in docker/compose#13138 - Bump golang to `1.23.12` by [@​austinvazquez](https://github.com/austinvazquez) in docker/compose#13142 #### New Contributors - [@​mattrunyon](https://github.com/mattrunyon) made their first contribution in docker/compose#13131 - [@​austinvazquez](https://github.com/austinvazquez) made their first contribution in docker/compose#13142 **Full Changelog**: docker/compose@v2.39.1...v2.39.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41OC4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
What I did
Added
go
to the prerequisite section inBUILDING.md