Close connection after building or pulling #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aanand Not sure what's going on, but you need to close it after each build :) Sorry if this is exactly what you done. |
93debf5 to
a5c1445
Compare
|
@LK4D4 Ah, good point. I've made it close after every build or pull. |
|
@aanand Why pull? :) |
This ensures that the connection is not recycled, which can cause the Docker daemon to complain if we've already performed another streaming call such as doing a build. Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
a5c1445 to
1a77fee
Compare
|
Oh, I assumed it applied to anything with streaming. Just build then. |
|
LGTM |
dnephin
added a commit
that referenced
this pull request
Apr 29, 2015
Close connection after building or pulling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the connection is not recycled, which can cause the Docker daemon to complain if we perform two streaming actions in a row.
Closes #1275.