Skip to content

Enhance JSON progress events with more fields. #12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

Enhance JSON progress events with more fields. #12000

merged 1 commit into from
Jul 23, 2024

Conversation

cmrigney
Copy link
Contributor

@cmrigney cmrigney commented Jul 22, 2024 •
edited by glours
Loading

What I did
I added the rest of the event fields to json progress events. Namely ParentID, Current, Total, and Percent.

Related issue

closes #11999

@cmrigney
Enhance JSON progress events with more fields.
8a0dc40 
Signed-off-by: Cody Rigney <cody.rigney@docker.com>
@cmrigney cmrigney force-pushed the enhance-json-progress branch from d383ce5 to 8a0dc40 Compare July 22, 2024 18:01
@glours glours requested review from a team, ndeloof, glours and jhrotko and removed request for a team July 23, 2024 08:43
glours
glours approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 44337d2 into docker:main Jul 23, 2024
30 checks passed
@cmrigney cmrigney deleted the enhance-json-progress branch July 23, 2024 14:24
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof is a code owner automatically assigned from docker/compose-maintainers

@jhrotko jhrotko Awaiting requested review from jhrotko jhrotko is a code owner automatically assigned from docker/compose-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON progress writer is missing some event fields
3 participants
@cmrigney @glours @ndeloof