Skip to content

Conversation

mountdisk
Copy link
Contributor

What I did

fix some minor issues in the comments

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

image

@mountdisk mountdisk requested a review from a team as a code owner June 30, 2025 06:49
@mountdisk mountdisk requested review from ndeloof and glours June 30, 2025 06:49
@ndeloof
Copy link
Contributor

ndeloof commented Jun 30, 2025

please sign-off your commit (required for legal reasons...)

@mountdisk
Copy link
Contributor Author

please sign-off your commit (required for legal reasons...)

Thanks. Signed.

@glours
Copy link
Contributor

glours commented Jul 1, 2025

@mountdisk it seems you didn't sign correctly your commit, you can follow this advices to do it

Signed-off-by: mountdisk <mountdisk@icloud.com>
@mountdisk
Copy link
Contributor Author

@mountdisk it seems you didn't sign correctly your commit, you can follow this advices to do it

Oh. Sorry for my mistake.

Modified. Please review again.

@ndeloof ndeloof enabled auto-merge (rebase) July 2, 2025 05:20
@ndeloof ndeloof merged commit b046a5e into docker:main Jul 2, 2025
25 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 9, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.38.1` -> `v2.38.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.38.2`](https://github.com/docker/compose/releases/tag/v2.38.2)

[Compare Source](docker/compose@v2.38.1...v2.38.2)

#### What's Changed

##### ✨ Improvements

- Add `--networks` flag to config command by [@&#8203;jarqvi](https://github.com/jarqvi) in docker/compose#13021

##### 🐛 Fixes

- Add a Done event to model progress display by [@&#8203;glours](https://github.com/glours) in docker/compose#13008
- Fix the way we're checking if the provider metadata are empty or not by [@&#8203;glours](https://github.com/glours) in docker/compose#13017
- Build: fix service with profile missing secrets by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13023
- Fix select dockerignore based on Dockerfile name set from symlink by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13024

##### 🔧  Internal

- pkg/compose: remove redundant uses of strslice.StrSlice by [@&#8203;thaJeztah](https://github.com/thaJeztah) in docker/compose#13002
- (reactoring) avoid a global variable by introducing logConsumer decorator by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12945
- Chore: fix some minor issues in the comments by [@&#8203;mountdisk](https://github.com/mountdisk) in docker/compose#12991
- A single place for shell-out command setup by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13007
- Add USER\_AGENT variable to cmd when shellouting by [@&#8203;glours](https://github.com/glours) in docker/compose#13025

##### ⚙️ Dependencies

- Bump golang to v1.23.10 by [@&#8203;glours](https://github.com/glours) in docker/compose#13004
- Bump go-viper/mapstructure to version v2.3.0 by [@&#8203;glours](https://github.com/glours) in docker/compose#13005
- Build(deps): bump github.com/moby/buildkit from 0.23.1 to 0.23.2 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13009
- Build(deps): bump github.com/docker/cli from 28.3.0+incompatible to 28.3.1+incompatible by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13012
- Build(deps): bump github.com/docker/docker from 28.3.0+incompatible to 28.3.1+incompatible by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13011

#### New Contributors

- [@&#8203;mountdisk](https://github.com/mountdisk) made their first contribution in docker/compose#12991

**Full Changelog**: docker/compose@v2.38.1...v2.38.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants