Skip to content

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jun 16, 2025

Use a LogConsumer Decorator to add support for navigation menu, without logConsumer to be aware -> no more dependency to navigation menu, nor global variable

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested a review from a team as a code owner June 16, 2025 09:41
@ndeloof ndeloof requested a review from glours June 16, 2025 09:41
…ator

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) July 1, 2025 10:21
@glours glours merged commit 6fa1731 into docker:main Jul 1, 2025
50 of 51 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 9, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.38.1` -> `v2.38.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.38.2`](https://github.com/docker/compose/releases/tag/v2.38.2)

[Compare Source](docker/compose@v2.38.1...v2.38.2)

#### What's Changed

##### ✨ Improvements

- Add `--networks` flag to config command by [@&#8203;jarqvi](https://github.com/jarqvi) in docker/compose#13021

##### 🐛 Fixes

- Add a Done event to model progress display by [@&#8203;glours](https://github.com/glours) in docker/compose#13008
- Fix the way we're checking if the provider metadata are empty or not by [@&#8203;glours](https://github.com/glours) in docker/compose#13017
- Build: fix service with profile missing secrets by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13023
- Fix select dockerignore based on Dockerfile name set from symlink by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13024

##### 🔧  Internal

- pkg/compose: remove redundant uses of strslice.StrSlice by [@&#8203;thaJeztah](https://github.com/thaJeztah) in docker/compose#13002
- (reactoring) avoid a global variable by introducing logConsumer decorator by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12945
- Chore: fix some minor issues in the comments by [@&#8203;mountdisk](https://github.com/mountdisk) in docker/compose#12991
- A single place for shell-out command setup by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#13007
- Add USER\_AGENT variable to cmd when shellouting by [@&#8203;glours](https://github.com/glours) in docker/compose#13025

##### ⚙️ Dependencies

- Bump golang to v1.23.10 by [@&#8203;glours](https://github.com/glours) in docker/compose#13004
- Bump go-viper/mapstructure to version v2.3.0 by [@&#8203;glours](https://github.com/glours) in docker/compose#13005
- Build(deps): bump github.com/moby/buildkit from 0.23.1 to 0.23.2 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13009
- Build(deps): bump github.com/docker/cli from 28.3.0+incompatible to 28.3.1+incompatible by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13012
- Build(deps): bump github.com/docker/docker from 28.3.0+incompatible to 28.3.1+incompatible by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#13011

#### New Contributors

- [@&#8203;mountdisk](https://github.com/mountdisk) made their first contribution in docker/compose#12991

**Full Changelog**: docker/compose@v2.38.1...v2.38.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants