fix panic using w shortcut on project without watch support #12944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
Jun 16, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 23, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.37.1` -> `v2.37.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.37.2`](https://github.com/docker/compose/releases/tag/v2.37.2) [Compare Source](docker/compose@v2.37.1...v2.37.2) #### What's Changed ##### ✨ Improvements - introduce `use_api_socket` by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12908 ##### 🐛 Fixes - restore ContainerName in images --json by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12943 - fix panic using w shortcut on project without watch support by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12944 ##### 🔧 Internal - move `run` logic inside backend by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12908 ##### ⚙️ Dependencies - bump compose-go to v2.6.5 by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12958 - build(deps): bump github.com/containerd/containerd/v2 from 2.1.1 to 2.1.2 by [@​dependabot](https://github.com/dependabot) in docker/compose#12939 **Full Changelog**: docker/compose@v2.37.1...v2.37.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
TIL: in Go, interface has a type and value, and as such
watch == nilis always false, while value is nil 🤪the only way to know is by reflection (so this is bascally considered an anti-pattern)
.. but as long as we want
wto open a link if watch is not configured 🤨, there's no better wayRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did