Skip to content

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 22, 2025

What I did
BuildOptions must be configured with same services as CreateOptions to detect the need for additional services resolution

Related issue
closes #12861

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested a review from a team as a code owner May 22, 2025 12:15
@ndeloof ndeloof requested a review from glours May 22, 2025 12:15
@ndeloof ndeloof enabled auto-merge (rebase) May 22, 2025 12:22
@ndeloof ndeloof merged commit a2d7548 into docker:main May 22, 2025
25 checks passed
@ndeloof ndeloof deleted the fix_build_additional_context branch May 22, 2025 12:34
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 26, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.36.1` -> `v2.36.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.36.2`](https://github.com/docker/compose/releases/tag/v2.36.2)

[Compare Source](docker/compose@v2.36.1...v2.36.2)

#### What's Changed

##### 🐛 Fixes

-   Run ContainerStart sequentially by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12851
-   Only use attestation when building image outside the development inner loop by [@&#8203;glours](https://github.com/glours) in docker/compose#12853
-   Report error (re)creating container by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12859
-   Fix `up --build` with additional_context dependency by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12863

##### 🔧  Internal

-   Add example provider implementation by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12848
-   Add `up --build` e2e test by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12864

##### ⚙️ Dependencies

-   Build(deps): bump github.com/containerd/containerd/v2 from 2.1.0 to 2.1.1 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#12857
-   Bump compose-go to v2.6.4 by [@&#8203;glours](https://github.com/glours) in docker/compose#12867
-   Bump buildkit v0.22.0 and buildx v0.24.0 by [@&#8203;glours](https://github.com/glours) in docker/compose#12868

**Full Changelog**: docker/compose@v2.36.1...v2.36.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yNi4xIiwidXBkYXRlZEluVmVyIjoiNDAuMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Vasilijez added a commit to magley/mocker-hub that referenced this pull request Jun 30, 2025
I have tested on the mirrored repository and got an error, even though I committed only a comment and made a pull request.

The problem was caused by GitHub runners. The last test related to the previous PR #43 was on June 19th. The runner image used by GitHub Actions was ubuntu-24.04 (20250602.3.0) with Docker Compose v2.36.0.

Today, GitHub Actions used the runner image ubuntu-24.04 (20250622.1.0) with Docker Compose v2.36.2.

If I understand correctly, the following PR introduced the issue, as services listed in `depends_on` are no longer automatically built before running the backend service. Because of that, I first build all services, as it is the best way to ensure that we don’t encounter a problem when the backend is up with any of its `depends_on` services.

docker/compose#12863

Locally, I didn’t have any issues with Docker Compose and running the exact same command, as the Docker Compose version on my PC is older and `build` services before `up`.

Used Ubuntu images:
https://github.com/actions/runner-images/blob/releases/ubuntu24/20250602/images/ubuntu/Ubuntu2404-Readme.md
https://github.com/actions/runner-images/blob/releases/ubuntu24/20250622/images/ubuntu/Ubuntu2404-Readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The new service: directive does not work with docker compose up --build
2 participants