run ContainerStart sequentially #12851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndeloof was this on Docker Desktop, or were you also able to reproduce on Linux? Wondering if it's the port mapping issues we've seen related to docker desktop. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
@thaJeztah only (randomly) applies to Linux, not DD. |
glours
approved these changes
May 20, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.36.1` -> `v2.36.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.36.2`](https://github.com/docker/compose/releases/tag/v2.36.2) [Compare Source](docker/compose@v2.36.1...v2.36.2) #### What's Changed ##### 🐛 Fixes - Run ContainerStart sequentially by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12851 - Only use attestation when building image outside the development inner loop by [@​glours](https://github.com/glours) in docker/compose#12853 - Report error (re)creating container by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12859 - Fix `up --build` with additional_context dependency by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12863 ##### 🔧 Internal - Add example provider implementation by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12848 - Add `up --build` e2e test by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12864 ##### ⚙️ Dependencies - Build(deps): bump github.com/containerd/containerd/v2 from 2.1.0 to 2.1.1 by [@​dependabot](https://github.com/dependabot) in docker/compose#12857 - Bump compose-go to v2.6.4 by [@​glours](https://github.com/glours) in docker/compose#12867 - Bump buildkit v0.22.0 and buildx v0.24.0 by [@​glours](https://github.com/glours) in docker/compose#12868 **Full Changelog**: docker/compose@v2.36.1...v2.36.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yNi4xIiwidXBkYXRlZEluVmVyIjoiNDAuMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As compose calls ContainerStart concurrently, Docker engine sometimes fails to allocate a port in a range. This should be fixed in engine, but this preventive workaround has low impact on Compose
Related issue
closes #12846
(not mandatory) A picture of a cute animal, if possible in relation to what you did