Skip to content

enable profile when down is ran with explicit service names #11108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

enable profile when down is ran with explicit service names #11108

merged 1 commit into from
Oct 18, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 18, 2023

What I did
enable services explicitly selected by user running down command

Related issue
closes #11091

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof
enable profile when down is ran with explicit service names
16a7c20 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team October 18, 2023 10:21
glours
glours approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit af87f10 into docker:main Oct 18, 2023
@ndeloof ndeloof deleted the down-services branch October 18, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@nicksieger nicksieger Awaiting requested review from nicksieger nicksieger is a code owner automatically assigned from docker/compose-maintainers

@StefanScherer StefanScherer Awaiting requested review from StefanScherer StefanScherer is a code owner automatically assigned from docker/compose-maintainers

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza ulyssessouza is a code owner automatically assigned from docker/compose-maintainers

@milas milas Awaiting requested review from milas milas is a code owner automatically assigned from docker/compose-maintainers

@laurazard laurazard Awaiting requested review from laurazard laurazard is a code owner automatically assigned from docker/compose-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent/undefined behavior between default merges and those with profiles
2 participants
@ndeloof @glours