when ran with ANSI disabled, force progress=plain #11514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11514 +/- ##
==========================================
+ Coverage 58.27% 58.52% +0.24%
==========================================
Files 134 134
Lines 11546 11550 +4
==========================================
+ Hits 6729 6760 +31
+ Misses 4153 4130 -23
+ Partials 664 660 -4 ☔ View full report in Codecov by Sentry. |
laurazard
approved these changes
Feb 18, 2024
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
c474bbb to
4441b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
--ansi=neveris used to disable fancy terminal magic. This should also apply to the progress mode, so this one switch to raw "plain text" mode.