[BUG] --pull policy flag does not complain about invalid values and silently swallows subsequent options #11104
Description
Description
The new behaviour on --pull (from PR #10981 I think) just tripped me up.
The command I'd been using with previous versions was:
docker compose up --build --pull --detach && docker compose logs -f
Today I was finding the containers exiting when I ^C-ed from the logs. Initially I thought something was wrong with logs -f but it turned out it was never reaching the second command.
What was happening was --pull was reading --detach as its policy value so --detach was never getting to the up command. ^C was killing the up command, nothing to do with the logs command.
If up had failed to run and --pull had complained that "--detach is not a valid policy" the issue would have been more obvious.
Steps To Reproduce
- Run
docker compose up --pull --detach ^C
Compose Version
Docker Compose version v2.21.0
Docker Environment
Client: Docker Engine - Community
Version: 24.0.6
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.11.2
Path: /usr/libexec/docker/cli-plugins/docker-buildx
compose: Docker Compose (Docker Inc.)
Version: v2.21.0
Path: /usr/libexec/docker/cli-plugins/docker-compose
Server:
Containers: 3
Running: 3
Paused: 0
Stopped: 0
Images: 276
Server Version: 24.0.6
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Using metacopy: false
Native Overlay Diff: true
userxattr: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Cgroup Version: 1
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 61f9fd88f79f081d64d6fa3bb1a0dc71ec870523
runc version: v1.1.9-0-gccaecfc
init version: de40ad0
Security Options:
apparmor
seccomp
Profile: builtin
Kernel Version: 5.15.0-1047-aws
Operating System: Ubuntu 20.04.6 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 7.674GiB
Name: ip-172-31-45-113
ID: e22db929-e459-4698-a63c-f6984d478327
Docker Root Dir: /var/lib/docker
Debug Mode: false
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
Anything else?
No response