Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/compose
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.12.1
Choose a base ref
...
head repository: docker/compose
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.12.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Oct 21, 2022

  1. go.mod: docker 5aac513617f072b15322b147052cbda0d451d389 / v22.06-dev 

    This restores compatibility with go1.18, which was broken since commit;
moby/moby@c062238

cmd.Environ() is new in go1.19, and not needed for this specific case.
Without this, trying to use this package in code that uses go1.18 will fail;

    builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ)

Changing to use `os.Environ()` instead restores compatibility with go1.18

Full diff: moby/moby@f9cb47a...5aac513

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    533abc3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9940 from thaJeztah/go1.18_compat 

    go.mod: docker 5aac513617f072b15322b147052cbda0d451d389 / v22.06-dev
    @thaJeztah
    thaJeztah authored Oct 21, 2022
    1 Configuration menu
    Copy the full SHA
    f472ce3 View commit details
    Browse the repository at this point in the history
Loading