Skip to content

Conversation

jsternberg
Copy link
Collaborator

The --keep-storage flag was changed to --reserved-space. Before it was
changed to that name, it was changed to --max-storage. This flag never
made it into a release as the name was changed before release, but the
update to the flag in buildx forgot to update the deprecation notice.

Fixes moby/moby#50120.

The `--keep-storage` flag was changed to `--reserved-space`. Before it was
changed to that name, it was changed to `--max-storage`. This flag never
made it into a release as the name was changed before release, but the
update to the flag in buildx forgot to update the deprecation notice.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@crazy-max crazy-max added this to the v0.24.1 milestone Jun 2, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max modified the milestones: v0.24.1, v0.25.0 Jun 2, 2025
@crazy-max crazy-max merged commit e6ff731 into docker:master Jun 2, 2025
139 checks passed
@jsternberg jsternberg deleted the keep-storage-deprecation-notice branch June 2, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builder prune says keep-storage is deprecated but suggested replacement doesn't work
3 participants