Skip to content

go.mod: downgrade minimum go version to go1.22 #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

go.mod: downgrade minimum go version to go1.22 #2977

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Member

This was updated in abc85c3, but looks to have been unintentional.

@thaJeztah
go.mod: downgrade minimum go version to go1.22
cc55bb0 
This was updated in abc85c3, but looks
to have been unintentional.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Feb 10, 2025 •
edited
Loading

Derp, looks like it actually no longer allows go1.22 😞

=== Errors
Error: util/buildflags/attests_cty.go:27:21: cannot range over eachElement(in) (value of type iter.Seq[cty.Value]): requires go1.23 or later (-lang was set to go1.22; check go.mod)
Error: util/buildflags/cache_cty.go:26:21: cannot range over eachElement(in) (value of type iter.Seq[cty.Value]): requires go1.23 or later (-lang was set to go1.22; check go.mod)
Error: util/buildflags/export_cty.go:26:21: cannot range over eachElement(in) (value of type iter.Seq[cty.Value]): requires go1.23 or later (-lang was set to go1.22; check go.mod)
Error: util/buildflags/secrets_cty.go:33:21: cannot range over eachElement(in) (value of type iter.Seq[cty.Value]): requires go1.23 or later (-lang was set to go1.22; check go.mod)
Error: util/buildflags/ssh_cty.go:33:21: cannot range over eachElement(in) (value of type iter.Seq[cty.Value]): requires go1.23 or later (-lang was set to go1.22; check go.mod)

Looks like it's because of a utility function that was added that uses Yield;

buildx/util/buildflags/utils.go

Lines 60 to 73 in 0a4eb7e

func eachElement(in cty.Value) iter.Seq[cty.Value] {
return func(yield func(v cty.Value) bool) {
for elem := in.ElementIterator(); elem.Next(); {
_, value := elem.Element()
if isEmptyOrUnknown(value) {
continue
}
if !yield(value) {
return
}
}
}
}

@thaJeztah thaJeztah mentioned this pull request Feb 10, 2025
Merged
@crazy-max crazy-max mentioned this pull request Feb 11, 2025
Merged
@thaJeztah thaJeztah deleted the downgrade_go_version branch February 11, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thaJeztah