Skip to content

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 16, 2024

fixes #2738

By default if there is no Run / RunE in parent command, cobra will just print help and exit 0.

No regression point, it fails since first release https://github.com/docker/buildx/releases/tag/v0.2.0 in plugin mode (docker buildx) but "only" since v0.9.0 in standalone.

@crazy-max crazy-max force-pushed the cli-fix-unknown-command branch from 4c5656c to 3c6c7c8 Compare October 16, 2024 14:44
@crazy-max crazy-max marked this pull request as ready for review October 16, 2024 14:45
@crazy-max crazy-max added this to the v0.18.0 milestone Oct 16, 2024
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the cli-fix-unknown-command branch from 3c6c7c8 to cc286e2 Compare October 18, 2024 12:04
@tonistiigi tonistiigi merged commit 08a973a into docker:master Oct 23, 2024
106 checks passed
@crazy-max crazy-max deleted the cli-fix-unknown-command branch October 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error messages on unknown command
2 participants