Skip to content

build: use better references for --call fallback images #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

build: use better references for --call fallback images #2705

merged 1 commit into from
Sep 25, 2024

Conversation

tonistiigi
Copy link
Member

  • printFallbackImage -> this image was actually 1.7.0 and using wrong text tag. Updated in build: add fallback image for --print=lint #2406 . I don't think it makes sense to use .0 that has a patch release with bugfixes so updated to that.
  • printLintFallbackImage -> pull the reference from production dockerfile upstream instead of staging area. The image is the same but users would previously see confusing "upstream" repo in the progress.

@tonistiigi
build: use better references for --call fallback images
f8657e8 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@crazy-max crazy-max merged commit d078a30 into docker:master Sep 25, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonistiigi @crazy-max