Skip to content

chore: switch to LocalMounts implementation #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore: switch to LocalMounts implementation #2254

merged 1 commit into from
Mar 14, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 10, 2024 •
edited
Loading

@crazy-max crazy-max mentioned this pull request Feb 10, 2024
Closed
@crazy-max crazy-max force-pushed the rm-local-dirs branch 5 times, most recently from 6c14050 to 5a7b9d9 Compare February 12, 2024 08:29
tonistiigi
tonistiigi reviewed Feb 13, 2024
View reviewed changes
@crazy-max crazy-max force-pushed the rm-local-dirs branch 2 times, most recently from 0a58879 to 97e626e Compare February 13, 2024 10:20
@crazy-max crazy-max marked this pull request as ready for review February 13, 2024 10:26
@crazy-max crazy-max force-pushed the rm-local-dirs branch 6 times, most recently from 5ab6dbf to 767ebf9 Compare February 23, 2024 22:22
tonistiigi
tonistiigi reviewed Feb 23, 2024
View reviewed changes
@crazy-max crazy-max requested a review from tonistiigi February 23, 2024 22:36
@crazy-max crazy-max force-pushed the rm-local-dirs branch 3 times, most recently from 996b82d to 35ba4d6 Compare February 26, 2024 09:03
@crazy-max crazy-max added this to the v0.13.0 milestone Feb 27, 2024
@tonistiigi tonistiigi removed this from the v0.13.0 milestone Feb 28, 2024
@tonistiigi
Copy link
Member

I removed this from the milestone as I don't think it has a user-visible impact. Lets get this in right after the release.

tonistiigi
tonistiigi reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can separate out the first commit. Makes reviewing easier.

@crazy-max crazy-max mentioned this pull request Mar 12, 2024
Merged
@crazy-max
chore: switch to LocalMounts implementation
b240a00 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi March 13, 2024 17:59
@tonistiigi tonistiigi merged commit 2565c74 into docker:master Mar 14, 2024
@crazy-max crazy-max deleted the rm-local-dirs branch March 14, 2024 18:38
@tonistiigi tonistiigi mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi