Fix a couple --invoke
entrypoint interaction bugs
#1870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
--invoke
against images that haveCmd
set, the interactions withEntrypoint
start to cause issues like the following:Or:
This patch fixes those by explicitly setting
Cmd
to be empty if it is unspecified andEntrypoint
is being set, which matchesdocker
's behavior:(There are still some weird edge cases in the interaction between the
InvokeConfig
and the original image config, but this fixes the most irritating for me and the rest are going to be deeper changes that are possibly less acceptable. 😅)