Skip to content

inspect: display builder features #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

inspect: display builder features #1854

merged 1 commit into from
Jun 6, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented May 30, 2023 •
edited
Loading

While working on #1846, I wanted to know nodes capability for some builders. I think we should display the list of features when inspecting a builder.

$ docker --debug buildx inspect docker2010
Name:   docker2010
Driver: docker

Nodes:
Name:      docker2010
Endpoint:  docker2010
Status:    running
Buildkit:  v0.8.2+eeb7b65
Platforms: linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
Features:
 Cache export:       false
 Docker exporter:    false
 History API:        false
 Multiple platforms: false
 OCI exporter:       false

$ docker --debug buildx inspect docker2010
Name:          default
Driver:        docker
Last Activity: 2023-05-30 12:30:59 +0000 UTC

Nodes:
Name:      default
Endpoint:  default
Status:    running
Buildkit:  v0.11.6
Platforms: linux/amd64, linux/amd64/v2, linux/amd64/v3, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
Features:
 Cache export:       false
 Docker exporter:    false
 History API:        true
 Multiple platforms: false
 OCI exporter:       false
GC Policy rule#0:
 All:           false
 Filters:       type==source.local,type==exec.cachemount,type==source.git.checkout
 Keep Duration: 172.8µs
 Keep Bytes:    2.764GiB
GC Policy rule#1:
 All:           false
 Keep Duration: 5.184ms
 Keep Bytes:    20GiB
GC Policy rule#2:
 All:        false
 Keep Bytes: 20GiB
GC Policy rule#3:
 All:        true
 Keep Bytes: 20GiB

@crazy-max crazy-max requested review from tonistiigi and jedevc May 30, 2023 12:34
jedevc
jedevc approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for when we merge the history API detection 🎉

@crazy-max crazy-max added this to the v0.11.0 milestone May 30, 2023
@crazy-max crazy-max marked this pull request as ready for review May 30, 2023 18:40
@tonistiigi
Copy link
Member

I guess this is fine although some of these were not designed to be user-visible but just the booleans that client code could use when handling flags. No way is this meant to be the same as BuildKit's cap-based feature detection for example.

@crazy-max
inspect: display builder features
6c9436f 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Now displays features only if debug is enabled.

@jedevc jedevc merged commit fcb7810 into docker:master Jun 6, 2023
@crazy-max crazy-max deleted the inspect-features branch June 6, 2023 15:30
@crazy-max crazy-max mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @tonistiigi @jedevc