build: display build details link #1841
Conversation
build/build.go
Outdated
| Node: node.Name, | ||
| Ref: so.Ref, | ||
| } | ||
| } | ||
| if resultHandleFunc != nil { | ||
| resultCtx, err := NewResultContext(ctx, cc, so, res) |
There was a problem hiding this comment.
@jedevc If we want to print in commands pkg I was wondering if we could use the result context handler to set the build details opts?
There was a problem hiding this comment.
ResultContext doesn't leave outside the controller boundary, so that would likely only work for the runBasicBuild case I think 😢 Although, we do record the build options, so controller.Inspect could work for this?
Though that's only the controller options, not the full solve request.
There was a problem hiding this comment.
Ah right thanks for the feedback, I will take a closer look.
There was a problem hiding this comment.
Builder name, node name when driver pairs are computed during build are not inputs so doesn't look good to have it in build options. Same for the refID computed for each solve opt.
73486dd to
f6c0278
Compare
|
@crazy-max Looks like multiple CI issues. |
|
These comments have not been resolved:
The link is not shown at all on error anymore iiuc. I'm not sure if we should show the link with |
7a39d38 to
a59d72f
Compare
Moved to commands package
Added detection using
It now prints on error as well. I was looking at using |
375b537 to
91677bf
Compare
f896fed to
e41911f
Compare
We are using the quiet flag option and we are not taking progress quiet mode into account Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
record-2023-05-31.141327.mp4
Display build details links if Docker Desktop build backend is enabled.
I'm using an OSC 8 escape sequence with the target links to be displayed in the terminal. Most of the terminal emulators auto-detect when a URL appears onscreen and allow to conveniently open them (e.g. via Ctrl+click or Cmd+click, or the right click menu). A hyperlink is opened upon encountering an OSC 8 escape sequence with the link. The list of supporting terminal emulators and terminal-based apps can be seen here: https://github.com/Alhadis/OSC8-Adoption/.
Atm it only displays links when build is completed and not for active builds. For active builds we need to put links right before build starts so user can just follow build status in desktop instead of his terminal. Would also need a callback to retrieve the ref when attributes are converted to solve opts.