Skip to content

kubernetes driver: add serviceaccount opt #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2023
Merged

kubernetes driver: add serviceaccount opt #1597

merged 2 commits into from
May 2, 2023

Conversation

robertlestak
Copy link

@robertlestak robertlestak commented Feb 4, 2023 •
edited
Loading

Addresses #766

Adds a new (optional) serviceaccount opt. When provided, it will be set as the created pod's serviceAccountName.

Example usage:

docker buildx create --name example \
    --driver kubernetes \
    --driver-opt=serviceaccount=example-sa

@robertlestak robertlestak force-pushed the k8s-sa branch 2 times, most recently from 84e4287 to bce3c4e Compare February 4, 2023 03:08
@robertlestak robertlestak changed the title kubernetes driver: add serviceAccount opt kubernetes driver: add serviceaccount opt Feb 4, 2023
@crazy-max
Copy link
Member

PTAL @morlay @AkihiroSuda

crazy-max
crazy-max previously requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update reference docs please in https://github.com/docker/buildx/blob/master/docs/reference/buildx_create.md#-set-additional-driver-specific-options---driver-opt for the kubernetes driver?

@dvdksn Would also need follow-up in docs repo: https://docs.docker.com/build/drivers/kubernetes/

@jedevc jedevc added this to the v0.11.0 milestone Apr 4, 2023
@dvdksn dvdksn mentioned this pull request Apr 11, 2023
Merged
@dvdksn
Copy link
Contributor

dvdksn commented Apr 14, 2023 •
edited
Loading

side note @crazy-max, I think the section in the file you linked to is actually redundant, now that we have the full opt descriptions for each driver in the docs. If you agree, I can create a PR to clean up buildx_create.md

@crazy-max
Copy link
Member

side note @crazy-max, I think the section in the file you linked to is actually redundant, now that we have the full opt descriptions for each driver in the docs. If you agree, I can create a PR to clean up buildx_create.md

Ah sure yeah sounds good

robertlestak and others added 2 commits April 26, 2023 16:40
@jedevc
kubernetes driver: add serviceaccount opt
65037e4 
Signed-off-by: robertlestak <robert.lestak@umusic.com>
@jedevc
docs: add serviceaccount driver-opt for k8s driver
6bec8f6 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
Copy link
Collaborator

jedevc commented Apr 26, 2023

@crazy-max @dvdksn for the time being, I pushed a commit to update buildx_create.md - we can clean it up later.

Anything else blocking on merging this, so we can get it in v0.11?

@jedevc jedevc requested a review from crazy-max April 26, 2023 15:45
@jedevc jedevc linked an issue Apr 26, 2023 that may be closed by this pull request
Setting Service Account on Kubernetes Deployment #766
Closed
@jedevc jedevc dismissed crazy-max’s stale review May 2, 2023 11:55

Updated the docs

@jedevc jedevc merged commit 43a07f3 into docker:master May 2, 2023
@robertlestak robertlestak deleted the k8s-sa branch May 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees
No one assigned
Labels
area/driver/kubernetes
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Setting Service Account on Kubernetes Deployment
5 participants
@robertlestak @crazy-max @dvdksn @jedevc @AkihiroSuda