build: set remote origin url #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
reviewed
Jan 24, 2023
46addba to
093a68b
Compare
f455b5e to
ed91c32
Compare
tonistiigi
reviewed
Jan 25, 2023
util/gitutil/gitutil.go
Outdated
| if ru, err := c.clean(c.run("remote", "get-url", "upstream")); err == nil && ru != "" { | ||
| return ru, nil | ||
| } | ||
| // Otherwise try to get the remote URL from the first remote |
There was a problem hiding this comment.
I think we should just give up here. Using random remote gives random results.
There was a problem hiding this comment.
If there's only a single remote it makes sense that we should take that one IMO
There was a problem hiding this comment.
Give up like error out or skip setting vcs source in this case?
There was a problem hiding this comment.
Skip. Like we couldn't detect the origin.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
ed91c32 to
c1058c1
Compare
tonistiigi
approved these changes
Jan 25, 2023
jedevc
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1540
By default we use the first remote url when setting vcs url. This change will use origin url. If it fails, fallback to upstream url. Otherwise get the first remote url.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com