Skip to content

root: filter out useless commandConn.CloseWrite warning message #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2022
Merged

root: filter out useless commandConn.CloseWrite warning message #924

merged 2 commits into from
Jan 25, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 21, 2022 •
edited
Loading

relates to #764 (comment)
closes #813

also while doing further tests for docker/cli#3314 I encounter a case where some logs don't match the output format from docker/cli:

$ docker build ...
WARNING: Error loading config file: ...
WARN[0000] No output specified for docker-container driver. Build result will only remain in ...

now using cli writers for logrus and simplify output format for parity:

$ docker build ...
WARNING: Error loading config file: ...
WARNING: No output specified for docker-container driver. Build result will only remain in ...

@crazy-max
root: filter out useless commandConn.CloseWrite warning message
278f94a 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max mentioned this pull request Jan 21, 2022
Closed
tonistiigi
tonistiigi reviewed Jan 22, 2022
View reviewed changes
@crazy-max
root: simple output format on logrus for parity with cli
d3e56ea 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from tonistiigi January 25, 2022 07:55
@tonistiigi tonistiigi merged commit 6c69d97 into docker:master Jan 25, 2022
@crazy-max crazy-max deleted the log branch January 25, 2022 18:57
@crazy-max crazy-max added this to the v0.8.0 milestone Jan 26, 2022
@crazy-max crazy-max mentioned this pull request Aug 12, 2022
Merged
@jedevc jedevc mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi