[WIP] [jvm-packages] move dmatrix building into rabit env #5585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now, there are some unit tests failing. one is feature size checking in DMatrix, the other one is rabit timeout issue. Hi @trivialfis can you help on these issues? |
DMatrix needs to communicate with other partitions to make sure the number of features is consistent.
|
Is it possible that the number of DMatrix objects on each worker becomes different? Or the creation of these objects is not synchronised across workers for some reason? |
|
Let me add a DMatrix check. |
|
We merged a more moderate solution in #5581 given that there might be complications with this approach. |
|
Thx Rory, Closed this since #5581 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMatrix needs to communicate with other partitions to make sure the
number of features is consistent.