Build failure on musl (CMAKE) #5510
Description
Build environment: alpine docker container
XGBoost Version: 1.0.2 and master (works on 0.82)
Build Script:
git submodule init; git submodule update
mkdir build; cd build
cmake ..
build
Result:
[ 1%] Building CXX object rabit/CMakeFiles/rabit.dir/src/allreduce_base.cc.o
In file included from /xgboost/rabit/../dmlc-core/include/dmlc/././base.h:300,
from /xgboost/rabit/../dmlc-core/include/dmlc/./logging.h:16,
from /xgboost/rabit/../dmlc-core/include/dmlc/io.h:15,
from /xgboost/rabit/include/rabit/internal/utils.h:16,
from /xgboost/rabit/src/allreduce_base.h:18,
from /xgboost/rabit/src/allreduce_base.cc:14:
/xgboost/rabit/../dmlc-core/include/dmlc/build_config_default.h:31:27: fatal error: execinfo.h: No such file or director
y
31 | #define DMLC_EXECINFO_H <execinfo.h>
| ^
compilation terminated.
The actual error (execinfo) is a bit of red herring. Notice that the file being included is /build_config_default.h. That file should not be included here.
So going by the source above, DMLC_CORE_USE_CMAKE should be defined, but it is not.
To show that this is the problem, the build does succeed if I set the following on the shell before calling cmake and make, however that is only a very hacky workaround:
export CXXFLAGS="-DDMLC_CORE_USE_CMAKE -I/xgboost/build/dmlc-core/include"
So to further troubleshoot this, I ran the same cmake build on a glibc system. To trigger the error, I added the following line to the top of dmlc-core/include/dmlc/build_config_default.h
#error "Should never load this build_config_default"
And predictably, the build fails with
[ 1%] Building CXX object rabit/CMakeFiles/rabit.dir/src/allreduce_base.cc.o
cd /workspace/srcdir/xgboost/build/rabit && /opt/bin/c++ -I/workspace/srcdir/xgboost/rabit/include -I/workspace/srcdir/xgboost/rabit/../dmlc-core/include -O3 -DNDEBUG -fPIC -std=gnu++11 -o CMakeFiles/rabit.dir/src/allreduce_base.cc.o -c /workspace/srcdir/xgboost/rabit/src/allreduce_base.cc
In file included from /workspace/srcdir/xgboost/rabit/../dmlc-core/include/dmlc/././base.h:300,
from /workspace/srcdir/xgboost/rabit/../dmlc-core/include/dmlc/./logging.h:16,
from /workspace/srcdir/xgboost/rabit/../dmlc-core/include/dmlc/io.h:15,
from /workspace/srcdir/xgboost/rabit/include/rabit/internal/utils.h:16,
from /workspace/srcdir/xgboost/rabit/src/allreduce_base.h:18,
from /workspace/srcdir/xgboost/rabit/src/allreduce_base.cc:14:
/workspace/srcdir/xgboost/rabit/../dmlc-core/include/dmlc/build_config_default.h:10:2: error: #error "Should never load
this build_config_default"
#error "Should never load this build_config_default"
^~~~~
So, in summary, I think the cmake created configuration is not used by the xboost build currently. The builds succeed in a linux/glibc system since the default settings work in that environment, but using musl makes this issue apparent.