Skip to content

Use 'default' visibility for C symbols #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Use 'default' visibility for C symbols #138

merged 1 commit into from
Apr 24, 2020

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Apr 23, 2020 •
edited
Loading

This is useful when we want to hide all C++ symbols but keep C symbols visible. With this change, we can apply -fvisibility=hidden compiler flag everywhere and keep C symbols visible.

cc @trivialfis

@hcho3 hcho3 requested a review from trivialfis April 23, 2020 23:43
@hcho3 hcho3 mentioned this pull request Apr 24, 2020
Merged
@hcho3 hcho3 merged commit 4fb34a0 into dmlc:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis