Skip to content
This repository was archived by the owner on Feb 1, 2020. It is now read-only.

Conversation

liangfu
Copy link
Member

@liangfu liangfu commented Apr 9, 2018

No description provided.

@tqchen
Copy link
Member

tqchen commented Apr 13, 2018

I am in favor of the update, however not everything should be in identity mapping in my understand. @zhreshold is that right?

Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this change as well, though converted ops are not organized. But I suggest add some test at least for argument check, because there are lots of op with same name and functionality but different arguments.

@zhreshold
Copy link
Member

let me know once this is PR is complete, thanks @liangfu

@tqchen
Copy link
Member

tqchen commented May 29, 2018

c.f. #518 we will redirect further changes to tvm repo, please open a new PR there. Please invite the original set of reviewers when the new PR is opened so they can review and approve the changes

@tqchen tqchen closed this May 29, 2018
abergeron pushed a commit to abergeron/nnvm that referenced this pull request May 31, 2018
* improved conv2d for last group of workloads

* conv2d_nchw improved on 14_256_256 and 56_64_128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants