Skip to content

Fix malformed connection remote name when using ssh remote uri. #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix malformed connection remote name when using ssh remote uri. #1030

merged 1 commit into from
Sep 25, 2023

Conversation

tiaden
Copy link
Contributor

@tiaden tiaden commented Sep 11, 2023

Fixes an issue where the remote uri qemu+ssh://username@hostname:2222/system?foo=bar&bar=foo does not resolve to qemu:///system as remote name

@michaelbeaumont michaelbeaumont changed the title Fixes malformed connection remote name when using ssh remote uri. Fix malformed connection remote name when using ssh remote uri. Sep 25, 2023
@michaelbeaumont
Copy link
Collaborator

Thanks!

@michaelbeaumont michaelbeaumont merged commit 402171f into dmacvicar:main Sep 25, 2023
@tiaden tiaden deleted the url-fix branch September 25, 2023 18:48
@nohoster nohoster mentioned this pull request Oct 11, 2023
Closed
dmacvicar pushed a commit to jimnydev/terraform-provider-libvirt that referenced this pull request Sep 28, 2024
@tiaden @dmacvicar
Fix malformed connection remote name when using ssh remote uri (dmacv…
a624ad9 
…icar#1030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiaden @michaelbeaumont