Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21494"

Ugh isBinExp doesn't work for EXP.loweredAssignExp flags are not set for it even though the hierarchy matches.

The changes to foreachvar module will need to be considered separately. First, I need to confirm that it helps eliminate all memory leaks.

#21672

Normally the CI runners will build dmd once as debug and then rebuild with release.

Windows_VisualD_LDC x64_Debug is debug only. Causing it to run out of time.

Windows_VisualD_LDC x64_Debug is debug only. Causing it to run out of time.

These timeouts appear on different Azure pipelines. As part of the test run there is a build of the druntime unittests with version=PRINTF that usually runs for a couple of seconds, but sometimes for 15-20 minutes. You can find it in the logs starting with "Testing printf" and then producing a wall of "_d_arraysetlength..." lines. Enable timestamps to see how slow it runs.

More bugs:

#21695

#21697 EDIT: not actually a bug in test, test is doing what it is supposed to. Will need to have DFA off for it.

More null deref:

• dmd/compiler/test/runnable/test42.d

  Line 3641 in fc25ce9

  immutable Bug5504 c;

• dmd/compiler/test/runnable/test42.d

  Line 3644 in fc25ce9

  shared Bug5504b d;

• dmd/compiler/test/compilable/b1215.d

  Line 138 in fc25ce9

  auto a1 = new void[types[0].tsize]; // TypeIdentifier::toExpression

  and 139

• dmd/compiler/test/compilable/test14838.d

  Line 8 in fc25ce9

  C c;

Test that is ok, but will need DFA turned off for it:

• dmd/compiler/test/runnable/testassert.d

  Line 6 in fc25ce9

  void test8765()

• dmd/compiler/test/compilable/test20100.d

  Line 40 in fc25ce9

  assert(!arr.ptr);

Four of the other tests that are broken are a me to be fixed, and the timetrace test is once again needing its DFA specific output added.

Another test that can't have the DFA turned on for:

I'm attempting to disable the tests:

• xtest46
• xtest46_gc
• testassert

If that fails I'll remove them. They are supposed to fail. But I need the CI to continue and if they exist it won't.

Looks like I'm due for another rebase, BUT: I'm down to one report that I'd like to keep that isn't being emitted.

After that its just rewrite the reporting, hope nothing else comes up and it should be more or less done.

and an update to frontend.h

Yeah that gave it away that I need a rebase.