Skip to content

Fixed #34054 -- Created a new fixtures topic. #16112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fixed #34054 -- Created a new fixtures topic. #16112

merged 1 commit into from
Nov 2, 2022

Conversation

filiplajszczak
Copy link
Contributor

@filiplajszczak filiplajszczak commented Sep 25, 2022 •
edited
Loading

Up for discussion https://code.djangoproject.com/ticket/34054
Waiting for #16104 to to be decided upon.

@filiplajszczak filiplajszczak changed the title Fixed #34064. Adds Fixtures Topic. Fixed #34054. Adds Fixtures Topic. Sep 25, 2022
@filiplajszczak filiplajszczak force-pushed the fixtures-topic branch 2 times, most recently from e8bd46e to 02ca00f Compare September 26, 2022 19:35
@felixxm
Copy link
Member

felixxm commented Oct 13, 2022

@filiplajszczak Do you have time to keep working on this?

@filiplajszczak filiplajszczak marked this pull request as ready for review October 13, 2022 12:25
@filiplajszczak
Copy link
Contributor Author

I'm ok with the current state of is, but I would be happy to hear from @evildmp

felixxm
felixxm reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filiplajszczak Thanks 👍 I left small suggestions.

@filiplajszczak filiplajszczak force-pushed the fixtures-topic branch 3 times, most recently from 92ee518 to a825862 Compare November 1, 2022 09:19
@filiplajszczak
Copy link
Contributor Author

@felixxm applied suggestions, squashed & rebased.

@filiplajszczak @felixxm
Fixed #34054 -- Created a new fixtures topic.
6103059 
Moved material from django-admin document into a new document, and
added new material.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@felixxm felixxm changed the title Fixed #34054. Adds Fixtures Topic. Fixed #34054 -- Created a new fixtures topic. Nov 2, 2022
@felixxm
Copy link
Member

felixxm commented Nov 2, 2022

@filiplajszczak Thanks for updates ⭐ I pushed tiny edits.

@felixxm felixxm merged commit 6103059 into django:main Nov 2, 2022
@filiplajszczak
Copy link
Contributor Author

@felixxm Thanks, ref makes much more sense now as we have a target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filiplajszczak @felixxm