Skip to content

Server tcp_connect should allow disabling Nagle algorithm #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

Server tcp_connect should allow disabling Nagle algorithm #55

merged 2 commits into from
Nov 28, 2024

Conversation

jshin47
Copy link
Contributor

@jshin47 jshin47 commented Oct 24, 2024 •
edited
Loading

I submitted a proposal to work on this project, and I wanted to show I can handle a simple ticket.

@dizda
Copy link
Owner

dizda commented Oct 24, 2024

Thank you, could you possibly rename it to nodelay, to keep the same consistency with the TCP/Tokio's setting?

@jshin47
Copy link
Contributor Author

jshin47 commented Oct 24, 2024

No problem

@dizda
Copy link
Owner

dizda commented Oct 24, 2024

Thank you. LGTM 👍

@dizda dizda merged commit 8002e1d into dizda:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshin47 @dizda