fix regression in displaying export errors #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced by: cf9222e refactor: better error handling for Dump and Error At this point in the control flow, `err` is non-nil if there was an error in config.EnvFromRC. We depend on it remaining non-nil until the return statement. cf9222e inadvertently unconditionally overwrote `err`, causing this function to never report errors from config.EnvFromRC. Fixed by giving the new error a different name. You can test the issue by editing this repo's .envrc file and then running `go run . export bash`. Fixes direnv#1463
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by cf9222e.
At this point in the control flow,
erris non-nil if there was an error in config.EnvFromRC. We depend on it remaining non-nil until the return statement. cf9222e inadvertently unconditionally overwroteerr, causing this function to never report errors from config.EnvFromRC. Fixed by giving the new error a different name.You can test the issue by editing this repo's .envrc file and then running
go run . export bash.Fixes #1463