refactor "export pwsh" to resolve issue #1254 #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlackHoleFox do you want to review this PR? Sorry I didn't get back to yours before. |
|
@bamsammich maybe as well? We don't have really good PowerShell tests. |
|
@zimbatm I ran out of energy to continue my original PR, so not all on you :) Saw a few things in the changeset I obviously missed doing in my attempt and nothing looks immediately incorrect. Not really a Go expert at the end of the day but I built this branch on my |
BlackHoleFox
approved these changes
Jun 14, 2025
|
sweet, thanks for testing! |
|
and thanks @LookoutHill for getting this over the line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve any issues related to #1254 by building on pull request #1255. By enforcing envvar creation of the form
${env:key} = 'value'and envvar removal withRemove-Item -LiteralPath 'env:key', these forms minimize interpolation of the keys and values and this minimizes special character processing which was split into 3 functions to address${env:key},'value', and'env:key'separately. All of these changes required changing the export line of the PowerShell hook from$export = /<PATH TO DIRENV>/direnv export pwsh;to$export = (/<PATH TO DIRENV>/direnv export pwsh) -join [Environment]::NewLine;. Some additional character value names were added tointernal/cmd/shell_bash.goto support the new special character processing.