Skip to content

add trailing newline to error messages #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025

Conversation

jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Apr 25, 2025

Fixes a regression in #1336, which caused error messages to display poorly (or in some cases not at all). See the linked issues.

Fixes #1425
Fixes #1431

Also deletes a duplicate ansi escape code.

errorColor was being used twice in a row.
@Arinerron
Copy link

Arinerron commented Jun 11, 2025

PLEASE

Please merge 🙏

@jeremyschlatter
Copy link
Contributor Author

@zimbatm @Mic92 any feedback on this PR? From the +1's it looks like a lot of people are impacted by the issue, and the fix is very simple.

@Mic92 Mic92 merged commit 63e9557 into direnv:master Jun 15, 2025
14 checks passed
@Arinerron
Copy link

Thank you @Mic92 @jeremyschlatter. Appreciate I didn't have to make the PR, haha!

@jeremyschlatter jeremyschlatter deleted the error-message-newline branch June 16, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

direnv error output gets removed by my terminal Error messages display poorly because they lack a trailing newline
3 participants