Skip to content

Add new env var DIRENV_LOG_VERBOSE to configure logging of export diff #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new env var DIRENV_LOG_VERBOSE to configure logging of export diff #1231

wants to merge 3 commits into from
+12 −6

Conversation

hlubek
Copy link

@hlubek hlubek commented Jan 19, 2024

See #68 .

This change adds a new env var that can be set to DIRENV_LOG_VERBOSE=0 to make the logging of exported variables much quieter (single line).

If logging should be completely disabled, the existing var can be set to DIRENV_LOG_FORMAT=, but this will disable all logging.

@jankatins jankatins mentioned this pull request Feb 12, 2024
Merged
@jankatins
Copy link

jankatins commented Feb 12, 2024 •
edited
Loading

#1234 has been merged (so this has merge conflicts) which can be used to hide the diff completely (but no counts like this PR)

zimbatm
zimbatm requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the config to the config file? I'm trying to move away from using env vars to configure direnv.

Otherwise looks good on principle.

@jankatins jankatins mentioned this pull request Apr 14, 2024
Open
@sudoforge
Copy link

sudoforge commented Apr 15, 2024 •
edited
Loading

Can you move the config to the config file? I'm trying to move away from using env vars to configure direnv.

Otherwise looks good on principle.

actually, i'd prefer to have this be configurable in a specific .envrc (using use_flake which outputs quite a few lines of env changes). #1234 doesn't provide for that use case, but this does. what would be a happy medium?

@kamushadenes
Copy link

Hello, can this be merged?

@hlubek
Copy link
Author

hlubek commented Oct 2, 2024

Hi there, I just noticed this open PR and merged the changes from master. I would suggest to show the count if the diff is hidden - this only adds one line to the output. I initially thought about adding a new config field show_diff_count, but that adds unnecessary complexity to understand two different boolean flags (where not every combination makes sense).

@sudoforge
Copy link

sudoforge commented Oct 2, 2024 •
edited
Loading

i strongly disagree with showing output if the hidden option is enabled. the point of hiding it is to prevent showing any output.

@hlubek
Copy link
Author

hlubek commented Oct 2, 2024

@sudoforge Would you rather introduce a new config field to show the count of exported variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm requested changes

+1 more reviewer

@haru02w haru02w haru02w approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hlubek @jankatins @sudoforge @kamushadenes @zimbatm @haru02w