Skip to content

elvish: replace deprecated except with catch #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

elvish: replace deprecated except with catch #987

merged 1 commit into from
Sep 21, 2022

Conversation

rsteube
Copy link
Contributor

@rsteube rsteube commented Sep 21, 2022 •
edited
Loading

@zimbatm zimbatm merged commit 8c435fc into direnv:master Sep 21, 2022
@zimbatm
Copy link
Member

zimbatm commented Sep 21, 2022

thanks!

@grawlinson
Copy link

This doesn't fix #914.

@rsteube
Copy link
Contributor Author

rsteube commented Nov 25, 2022

@grawlinson what's missing?

@grawlinson
Copy link

The elvish tests in the test directory still contain except statements.

@rsteube rsteube mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elvish hook outdated
3 participants
@rsteube @zimbatm @grawlinson