feat: allow conda environment names to be detected from environment.yml #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2227e90 to
09ec7c9
Compare
Currently an error is encountered if an environment name is not specified to `layout anaconda`. This change attempts to detect the environment name from the environment.yml file by grepping for the `name` property and processing the result. The result is that .envrc files can now simply contain `layout anaconda` as long as the local environment.yml file specifies a `name`. No new dependencies are introduced as `grep` is already used and additional processing is performed using Bash parameter expansion.
09ec7c9 to
77a33a0
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an error is encountered if an environment name is not
specified to
layout anaconda. This change attempts to detectthe environment name from the environment.yml file by grepping
for the
nameproperty and processing the result.The result is that .envrc files can now simply contain
layout anacondaas long as the local environment.ymlfile specifies a
name.No new dependencies are introduced as
grepis already usedand additional processing is performed using Bash parameter
expansion.