Skip to content

Allow optional leading v in .node-version file #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Allow optional leading v in .node-version file #833

wants to merge 2 commits into from

Conversation

shadowspawn
Copy link

This is a small suggested feature for convenience of users and greater compatibility with other products using .node-version. Feel free to reject!

Related use cases:

  1. Node includes a leading v when displaying its version. This might be written into a version control file:
$ node --version
v10.15.3
$ node --version > .node-version
  1. Most of the other node version managers that support .node-version file allow a leading v on the version.
  1. nvm supports leading v on version when used directly, and the v is included in the example here: https://github.com/direnv/direnv/wiki/Node

Now in any directory, put a Node version number like v14.15.4 in .nvmrc and put use nvm in .envrc.

Example file:

% cat .node-version 
v10.12.0

Before fix:

% direnv reload     
direnv: loading ~/node-version/eol-lin/.envrc                                                                                 
direnv: using node
direnv: Unable to load NodeJS binary (node) for version (v10.12.0) in (/usr/local/n/versions/node)!

After fix:

% direnv reload
direnv: loading ~/node-version/eol-lin/.envrc                                                                                 
direnv: using node
direnv: Successfully loaded NodeJS v10.12.0 (via .node-version), from prefix (/usr/local/n/versions/node/10.12.0)
direnv: export +CPATH +LD_LIBRARY_PATH +LIBRARY_PATH +MANPATH +PKG_CONFIG_PATH ~PATH

Paranoia: This could break users who are specifying a v which is part of the path to the node on disk with their setup. The work-around for the user would be to add the v into NODE_VERSION_PREFIX.

@shadowspawn
Copy link
Author

On a related note. If you are interested, I could also suggest changes to allow a Windows EOL in .node-version in this PR or separately as you prefer. I was not sure if you would be interested in Windows issues, but saw efforts in #630.

This is how I did it for n:
https://github.com/tj/n/blob/04ed355c4806fca2456b1ea9a7cf6ec202427c5b/bin/n#L1056

@shadowspawn
Copy link
Author

Happy to try and help if interested in future.

@zimbatm
Copy link
Member

zimbatm commented May 13, 2022

sorry I didn't get back to you.

I want to move language-specific helpers out of the stdlib as they cause most of the release churn and are best maintained by language experts. I always feel uncomfortable changing them as I don't know if it will break back-compat or not.

Instead of that, I propose:

  • language experts maintain direnv-<lang> repos
  • users use source_url to pull a pinned version of that repo.
  • the repos can be moved to the direnv org when they become stable.

@shadowspawn shadowspawn mentioned this pull request Sep 19, 2022
Closed
@shadowspawn shadowspawn mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @zimbatm