Dockerfile: switch to xx #3641
Merged
Dockerfile: switch to xx #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #3641 +/- ##
=======================================
Coverage 56.58% 56.58%
=======================================
Files 103 103
Lines 7520 7520
=======================================
Hits 4255 4255
Misses 2596 2596
Partials 669 669 Continue to review full report at Codecov.
|
thaJeztah
approved these changes
May 3, 2022
Comment on lines
+17
to
+18
| VERSION=$(git describe --match 'v[0-9]*' --dirty='.m' --always --tags) REVISION=$(git rev-parse HEAD)$(if ! git diff --no-ext-diff --quiet --exit-code; then echo .m; fi); \ | ||
| echo "-X ${PKG}/version.Version=${VERSION#v} -X ${PKG}/version.Revision=${REVISION} -X ${PKG}/version.Package=${PKG}" | tee /tmp/.ldflags; \ |
There was a problem hiding this comment.
I guess we can start using some of Go's built-in features for the git commit now (not for this PR!)
There was a problem hiding this comment.
isn't that only possible from 1.18 on?
milosgajdos
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #3639 (comment)
replace goreleaser-xx with xx. this adds a bit more logic to package and handle versioning that was carried by goreleaser-xx before but at least we only rely on go tooling to build.
cc @milosgajdos @thaJeztah
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com