Skip to content

Conversation

wy65701436
Copy link
Collaborator

Signed-off-by: Wang Yan wangyan@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #3518 (3f4c558) into main (1563384) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3518   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         101      101           
  Lines        7282     7282           
=======================================
  Hits         4109     4109           
  Misses       2523     2523           
  Partials      650      650           
Impacted Files Coverage Δ
...bution/distribution/registry/handlers/basicauth.go 100.00% <0.00%> (ø)
...tribution/registry/storage/blobwriter_resumable.go 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1563384...3f4c558. Read the comment docs.

@thaJeztah
Copy link
Member

We should probably also update the // +build build-tag comments to the new go1.17 style; similar to containerd/containerd#5903

Signed-off-by: Wang Yan <wangyan@vmware.com>
@wy65701436
Copy link
Collaborator Author

We should probably also update the // +build build-tag comments to the new go1.17 style; similar to containerd/containerd#5903

updated, thanks.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wy65701436 wy65701436 merged commit b106d89 into distribution:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants