Add ability to load s3 config from ~/.aws/config #3243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaun Sabo <shaunsabo@slack-corp.com>
|
Looks like a duplicate of #3245. |
|
I agree, looks like we effectively came to same solution too 😂 |
|
@olegburov I am going to close my PR in favor of yours. Please let me know if there is anything I can do to help out with your branch. |
|
@ssabo if you could double check that my changes still work for you that would add more confidence and help reviewes to approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shaun Sabo shaunsabo@slack-corp.com
I noticed that I cannot force the SDK to load my
.aws/configwhich I volume mounted into the registry container at/root/.aws/config. I want to do this so I can run a registry in a different AWS account from where the S3 bucket is located without using Access Keys. Ideally, I would like to achieve this by usingrole_arnandcredential_source = Ec2InstanceMetadatain the shared config to assume a role in the account where the bucket is located.Currently if we provide
AWS_SDK_LOAD_CONFIG=1to the registry, it will not actually use the config located at~/.aws/config. I believe this is becausedefaults.Config()loads a full*aws.Configobject who's Credentials override the detection thatsession.NewSession()does.By starting with a sparse object with
&aws.Config{}, I was able to continue to configure the session incrementally without wiping out default behavior for credential discovery.This patch will maintain existing behavior, except when
AWS_SDK_LOAD_CONFIG=1is set in the environment.