Skip to content

Upgrade Gorilla Mux to 1.8.0. #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Upgrade Gorilla Mux to 1.8.0. #3237

merged 1 commit into from
Nov 5, 2020

Conversation

ob1dev
Copy link
Contributor

@ob1dev ob1dev commented Aug 27, 2020

This PR upgrades Gorilla Mux from 1.7.2 to 1.8.0.

@ob1dev ob1dev marked this pull request as ready for review August 28, 2020 19:23
thaJeztah
thaJeztah requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits? Looks like these should all be in a single commit

@ob1dev
Bump Gorilla Mux to v1.8.0.
545596a 
Signed-off-by: olegburov <oleg.burov@outlook.com>
@ob1dev
Copy link
Contributor Author

ob1dev commented Aug 31, 2020

@thaJeztah done.

@ob1dev ob1dev requested a review from thaJeztah August 31, 2020 16:07
dmcgowan
dmcgowan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob1dev
Copy link
Contributor Author

ob1dev commented Sep 1, 2020

Here is a related PR #3242.

thaJeztah
thaJeztah approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@manishtomar @stevvooe PTAL

@arkodg arkodg merged commit f4506b5 into distribution:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ob1dev @thaJeztah @dmcgowan @arkodg