Thanks! Change itself looks good, but I see you forgot the DCO sign off in your commit message; https://github.com/docker/distribution/blob/master/CONTRIBUTING.md#sign-your-work

If you can amend your commit, and force-push, that should update the PR and make CI go green (no need to open a new PR if you amend your commit)

Thanks @thaJeztah, signed off on the commit 😊.

@manishtomar @dmcgowan ptal

@AndreasHassing Thanks for the PR. Could you update logrus in https://github.com/docker/go-metrics/ to latest version?

don't think go-metrics depends on logrus, unless it's through the prometheus client

Oh yes 🤦 . You are right. Looking at go mod graph it seems that both logrus versions are using go-windows-terminal-sequences package:

$ go mod graph | grep win
github.com/sirupsen/logrus@v1.6.0 github.com/konsorten/go-windows-terminal-sequences@v1.0.3
github.com/sirupsen/logrus@v1.2.0 github.com/konsorten/go-windows-terminal-sequences@v1.0.1

However, checking go mod graph in logrus doesn't reveal that package being used. So, I am curious where that package is coming from:

manish:~/src/logrus (master)
$ go mod graph
github.com/sirupsen/logrus github.com/davecgh/go-spew@v1.1.1
github.com/sirupsen/logrus github.com/pmezard/go-difflib@v1.0.0
github.com/sirupsen/logrus github.com/stretchr/testify@v1.2.2
github.com/sirupsen/logrus golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037

@manishtomar: the dependency is removed entirely from logrus between 1.6.0 and master, but they haven't released yet 😊.

@AndreasHassing Aah ok. Thanks a lot for the info.