Skip to content

Conversation

adamwg
Copy link
Contributor

@adamwg adamwg commented Jun 2, 2020

A repository need not contain any unique layers, if its images use only layers mounted from other repositories. But, the catalog endpoint was looking for the _layers directory to indicate that a directory was a repository.

Use the _manifests directory as the marker instead, since any repository with revisions will contain a _manifests directory.

Fixes #3172

Signed-off-by: Adam Wolfe Gordon awg@digitalocean.com

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A repository need not contain any unique layers, if its images use only layers
mounted from other repositories. But, the catalog endpoint was looking for the
_layers directory to indicate that a directory was a repository.

Use the _manifests directory as the marker instead, since any repository with
revisions will contain a _manifests directory.

Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>
@adamwg adamwg force-pushed the catalog-no-layers-upstream branch from 844397e to a784441 Compare August 4, 2020 17:39
@adamwg
Copy link
Contributor Author

adamwg commented Aug 4, 2020

Rebased onto master in hopes that will fix the CI failure.

@dmcgowan dmcgowan merged commit 35b26de into distribution:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repositories with no unique layers don't show up in _catalog
3 participants