Add s390x support for travis #3140
Conversation
Signed-off-by: Snehal Rajmane <srajmane@us.ibm.com>
.travis.yml
Outdated
| include: | ||
| - arch: amd64 | ||
| - arch: s390x | ||
| dist: bionic |
There was a problem hiding this comment.
I don't think we should test one on trusty and one on bionic. Tests could error because of differences between those two.
There was a problem hiding this comment.
s390x build runs within an LXD container on Z-based infrastructure. LXD containers are with (Bionic), Xenial only.
Reference: https://docs.travis-ci.com/user/reference/overview/
There was a problem hiding this comment.
@SuperSandro2000 Could you please have a look ?
There was a problem hiding this comment.
I have nothing to say here but a good approach would be to update the other tests also to bionic.
There was a problem hiding this comment.
@SuperSandro2000 Added dist: bionic for amd64 and s390x. Also set GO111MODULE=on to resolve l.LintPkg undefined (type *"github.com/golangci/lint-1".Linter has no field or method LintPkg) error.
Ref: https://github.com/golangci/golangci-lint#go
Signed-off-by: Snehal Rajmane <srajmane@us.ibm.com>
|
@thaJeztah @dmcgowan Please have a look. |
|
@thaJeztah What is our policy in general for other arch support? Do you think its sufficient to just have CI enabled? |
|
I don't think there's an official "policy" for this repository ( we are working with the IBM Power and Z teams on docker packages for those platforms, and we have CI running for those in the upstream moby repository) I don't think it hurts to have CI running to check if nothing breaks on those architectures |
|
Perhaps arm64 should be enabled as well if it doesn't considerably slow down testing on PR's |
|
Hi @olegburov , added s390x support to make sure nothing breaks for s390x. |
|
Sorry, I meant why does the Registry care of |
|
@olegburov I don't think this repo provides "official" support of |
|
Got it. The reason why I asked is, if we want to switch from Travis CI to GitHub Actions in some future, we will have to drop |
As Travis CI officially supports s390x builds, adding support for same.